Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #1343 #1668

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix issue #1343 #1668

wants to merge 1 commit into from

Conversation

slayer321
Copy link

do check and let me know if everything is correct

@acomodi
Copy link
Contributor

acomodi commented May 17, 2021

Hi @slayer321,
what would actually be needed is to change the name of the resulting binaries. The assignment of the binary names happens in https://github.com/SymbiFlow/prjxray/blob/master/tools/CMakeLists.txt.

Take the following as an example: https://github.com/SymbiFlow/prjxray/blob/80726cb73ba5c156549d98a2055f1ee3eff94530/tools/CMakeLists.txt#L7.

To change bittool to be xc7bittool you should modfiy that line to be:

add_executable(xc7bittool bittool.cc)
target_link_libraries(xc7bittool libprjxray gflags absl::strings absl::span)

Moreover, these tools are used in different parts in prjxray, so the change in the tools names need to be addressed also where the tools are used.

GitHub
Documenting the Xilinx 7-series bit-stream format. - SymbiFlow/prjxray

@slayer321
Copy link
Author

ok, I understood that I just need to change the name here in this file . and what about the changes that I did . that was not needed right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants