-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding connection to a Xilinx license server. #1805
Conversation
44870f2
to
0d18359
Compare
3a847a5
to
b411d96
Compare
Enables generation of database for larger Kintex parts. Signed-off-by: Tim 'mithro' Ansell <tansell@google.com>
b411d96
to
18dc22c
Compare
Was finally able to make this work!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with a small comment.
I am unsure how complex this might get in the scope of switching CI to GH custom runners, if this is still planned for prjxray, but I guess this is something to keep in mind.
( | ||
set -e | ||
cd /opt | ||
if [ x"$XRAY_SETTINGS" = x"kintex7" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might add a new env_vars
in the kokoro config to select which configuration uses which Vivado version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we could in a future version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same solution should hopefully work for custom GitHub Action runners...
Adding connection to a Xilinx license server.
Enables generation of database for larger Kintex parts.
Signed-off-by: Tim 'mithro' Ansell tansell@google.com