Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svelte error when using axis #86

Closed
vpanyushenko opened this issue Dec 27, 2022 · 4 comments · Fixed by #89
Closed

Svelte error when using axis #86

vpanyushenko opened this issue Dec 27, 2022 · 4 comments · Fixed by #89
Assignees
Labels
bug Something isn't working

Comments

@vpanyushenko
Copy link

The error message says Uncaught TypeError: Cannot read properties of undefined (reading 'config')

This seems to only happen when using VisAxis components when the whole component is getting destroyed, typically due to a page navigation.

Package versions:

  • "@sveltejs/kit": "^1.0.0",
  • "svelte": "^3.54.0",
  • "vite": "^4.0.0"
  • "@unovis/svelte": "^1.0.1",
  • "@unovis/ts": "^1.0.1",

I have a local reproduction repo here: https://github.com/vpanyushenko/unovis-svelte-repo and a live version here: https://unovis-svelte-repo-panyushenko.vercel.app/

To reproduce the issue:

  1. Click on the "chart" tab in the header which should successfully load the demo chart.
  2. Click back to the "home" tab and you'll notice it doesn't load. If you open the console, you'll see the error
  3. Refresh the home page
  4. Click on the "chart without axis" tab
  5. Click back to home. This one loads successfully, the only difference is that VisAxis is not being used.
@rokotyan rokotyan added the bug Something isn't working label Dec 29, 2022
@rokotyan rokotyan added this to the Release v1.0.2 milestone Dec 29, 2022
@rokotyan
Copy link
Contributor

@vpanyushenko Thanks for the detailed bug report! We'll look into it.

@rokotyan
Copy link
Contributor

rokotyan commented Jan 3, 2023

@vpanyushenko (cc @reb-dev )

I've just published version 1.0.2-beta.0 of the libraries that should fix the issue. Can you please check if it works on your end?

@vpanyushenko
Copy link
Author

It's working on my end. Thank you for the quick turnaround! I've updated the live link and repo with the new updates as well: https://unovis-svelte-repo-panyushenko.vercel.app/

@rokotyan
Copy link
Contributor

rokotyan commented Jan 3, 2023

@vpanyushenko Great, thanks for the quick check!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants