Component | Donut: Rendering empty segments #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@reb-dev I like your approach but it doesn't solve the wrong segment colors problem, when Also, can you please combine my WIP commit with yours and update the commit history? |
rokotyan
reviewed
Jan 24, 2023
reb-dev
force-pushed
the
fix/donut-empty-segments
branch
4 times, most recently
from
892dc76
to
1ad9a60
Compare
rokotyan
suggested changes
Jan 26, 2023
rokotyan
force-pushed
the
fix/donut-empty-segments
branch
from
19d979a
to
e0c49de
Compare
reb-dev
force-pushed
the
fix/donut-empty-segments
branch
from
e0c49de
to
2a4b16b
Compare
rokotyan
approved these changes
Jan 27, 2023
rokotyan
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the appearance of empty segments when
padAngleis set.