Component | Graph: Configurable node labels trimming #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reb-dev
reviewed
Feb 2, 2023
| @@ -143,8 +143,12 @@ export interface GraphConfigInterface<N extends GraphInputNode, L extends GraphI | |||
| nodeIconSize?: NumericAccessor<N>; | |||
| /** Node label accessor function or constant value. Default: `node => node.label` */ | |||
| nodeLabel?: StringAccessor<N>; | |||
| /** Defines whether to trim the node labels or not. Default: `true` */ | |||
| nodeLabelTrim?: BooleanAccessor<N>; | |||
There was a problem hiding this comment.
Should we support multiple trim types like we do with other components? i.e. make this a TrimMode accessor?
There was a problem hiding this comment.
@reb-dev We should, but I wanted to do it later along with overall refactoring of labels in the library. However, it can be a small change, I'll check
There was a problem hiding this comment.
@reb-dev I've added additional properties to configure trimming and extended the example accordingly
reb-dev
previously approved these changes
Feb 2, 2023
reb-dev
approved these changes
Feb 6, 2023
rokotyan
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#120
nodeLabelTrimandnodeSubLabelTrimconfig properties;