Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sankey: Better sizing logic #127

Merged
merged 3 commits into from
Feb 7, 2023
Merged

Sankey: Better sizing logic #127

merged 3 commits into from
Feb 7, 2023

Conversation

rokotyan
Copy link
Contributor

@rokotyan rokotyan commented Feb 3, 2023

This PR fixes Sankey sizing issues #126 and #52, and adds a new example to the dev app.

Screen.Recording.2023-02-03.at.10.05.26.AM.web.mp4

@rokotyan
Dev: Scrollable list of examples and visualization container
478c430 
#0
@rokotyan
Component | Sankey: Updated sizing function allowing container to shrink
0e150fc 
#126 Updated `getWidth` and `getHeight`
#52 Limiting Sankey dimensions
#0 Animated transform for `_nodesGroup` and `_linksGroup`
@rokotyan
Dev | Examples | Sankey: API Endpoints example
e2b2608 
#126 Updated `getWidth` and `getHeight`
@rokotyan rokotyan requested a review from reb-dev February 3, 2023 18:08
@rokotyan rokotyan added the fix Bug fix label Feb 3, 2023
@rokotyan rokotyan added this to the Release v1.0.3 milestone Feb 3, 2023
reb-dev
reb-dev reviewed Feb 6, 2023
View reviewed changes
Copy link
Collaborator

@reb-dev reb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rokotyan I notice if we remove the sizing prop from SingleContainer in the dev example, there is a lot of extra white space and overlapping labels. Should we fix that?

localhost_9500_examples_Sankey_API%20Endpoints%20Tree (2)

@rokotyan rokotyan mentioned this pull request Feb 6, 2023
Closed
@rokotyan
Copy link
Contributor Author

rokotyan commented Feb 6, 2023

@reb-dev At some point yes, but no as part of this PR. I've created a dedicated ticket for it.

reb-dev
reb-dev approved these changes Feb 6, 2023
View reviewed changes
Copy link
Collaborator

@reb-dev reb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

@rokotyan rokotyan merged commit e0128c5 into main Feb 7, 2023
reb-dev added a commit that referenced this pull request May 8, 2023
@reb-dev
Component | Nested Donut: Adding value accessor function
683143d 
#127
reb-dev added a commit that referenced this pull request May 8, 2023
@reb-dev
Website | Gallery: Nested Donut Sunburst chart example
16c149a 
#127
reb-dev added a commit that referenced this pull request May 19, 2023
@reb-dev
Component | Nested Donut: Adding value accessor function
b7e58fe 
#127
reb-dev added a commit that referenced this pull request May 19, 2023
@reb-dev
Website | Gallery: Nested Donut Sunburst chart example
6b80f5a 
#127
rokotyan pushed a commit that referenced this pull request May 19, 2023
@reb-dev @rokotyan
Component | Nested Donut: Adding value accessor function
ab60b3f 
#127
rokotyan pushed a commit that referenced this pull request May 19, 2023
@reb-dev @rokotyan
Website | Gallery: Nested Donut Sunburst chart example
aa37499 
#127
@rokotyan rokotyan deleted the fix/extended-component-sizing branch May 22, 2023 19:58
rokotyan pushed a commit that referenced this pull request May 22, 2023
@reb-dev @rokotyan
Component | Nested Donut: Adding value accessor function
e7861da 
#127
rokotyan pushed a commit that referenced this pull request May 22, 2023
@reb-dev @rokotyan
Website | Gallery: Nested Donut Sunburst chart example
bc17093 
#127
reb-dev added a commit that referenced this pull request May 26, 2023
@reb-dev
Component | Nested Donut: Define empty segment behavior
7a2aadb 
#127
reb-dev added a commit that referenced this pull request May 26, 2023
@reb-dev
@unovis/angular: Export Nested Donut component
9c19172 
#127
reb-dev added a commit that referenced this pull request May 26, 2023
@reb-dev
Component | Nested Donut: Define empty segment behavior
c07daed 
#127
reb-dev added a commit that referenced this pull request May 26, 2023
@reb-dev
@unovis/angular: Export Nested Donut component
4b97921 
#127
rokotyan pushed a commit that referenced this pull request May 30, 2023
@reb-dev @rokotyan
Component | Nested Donut: Define empty segment behavior
9e13e8a 
#127
rokotyan pushed a commit that referenced this pull request May 30, 2023
@reb-dev @rokotyan
@unovis/angular: Export Nested Donut component
521d403 
#127
rokotyan pushed a commit that referenced this pull request Jun 27, 2023
@reb-dev @rokotyan
Component | Nested Donut: Adding value accessor function
290af69 
#127
rokotyan pushed a commit that referenced this pull request Jun 27, 2023
@reb-dev @rokotyan
Website | Gallery: Nested Donut Sunburst chart example
15f30a3 
#127
rokotyan pushed a commit that referenced this pull request Jun 27, 2023
@reb-dev @rokotyan
Component | Nested Donut: Define empty segment behavior
77de5d1 
#127
rokotyan pushed a commit that referenced this pull request Jun 27, 2023
@reb-dev @rokotyan
@unovis/angular: Export Nested Donut component
b382024 
#127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reb-dev reb-dev reb-dev approved these changes

Assignees

@reb-dev reb-dev

Labels
fix Bug fix
Projects
None yet
Milestone
Release v1.0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@rokotyan @reb-dev