Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component | XYLables: Setting stroke via CSS variables #99

Merged
merged 2 commits into from
Jan 12, 2023

Conversation

rokotyan
Copy link
Contributor

Fixes #98. Stroke can now be set via CSS variables:

.stackBarLabels g[alert] {
  --vis-xy-label-stroke-color: white;
  --vis-xy-label-stroke-width: 1px;
}

.stackBarLabels g[alert][cluster] {
  --vis-xy-label-stroke-width: 2px;
}

Screen Shot 2023-01-12 at 9 49 54 AM

@rokotyan rokotyan added the bug Something isn't working label Jan 12, 2023
@rokotyan rokotyan added this to the Release v1.0.2 milestone Jan 12, 2023
@rokotyan rokotyan requested a review from reb-dev January 12, 2023 17:51
Copy link
Collaborator

@reb-dev reb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rokotyan Should we also include CSS variables for dark theme?

@rokotyan
Copy link
Contributor Author

@reb-dev Good point, I was also thinking about it. But I'm planning some additional work for this component soon, so we can cover it then.

Copy link
Collaborator

@reb-dev reb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rokotyan rokotyan merged commit cbfb045 into main Jan 12, 2023
@rokotyan rokotyan mentioned this pull request Feb 15, 2023
@rokotyan rokotyan deleted the fix/xy-labels-stroke branch May 22, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Component | XYLables: Changing stroke via CSS variables doesn't work
2 participants