Fixed issue with typed builder on phantom data #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed clippy issues
ManevilleF
commented
Sep 7, 2021
| @@ -45,7 +45,7 @@ async fn test_get_url() { | |||
| let conn = Connection::establish_jwt(&host, &user, &password) | |||
| .await | |||
| .unwrap(); | |||
| let url = conn.url().clone().into_string(); | |||
| let url: String = conn.url().clone().into(); | |||
There was a problem hiding this comment.
Fixed deprecation warning of the into_string method
ManevilleF
commented
Sep 7, 2021
| impl<T> Into<Result<T, ArangoError>> for Response<T> { | ||
| fn into(self) -> Result<T, ArangoError> { | ||
| match self { | ||
| impl<T> From<Response<T>> for Result<T, ArangoError> { |
There was a problem hiding this comment.
Clippy prefers From implementations
ManevilleF
commented
Sep 7, 2021
| @@ -349,7 +349,7 @@ impl<C: ClientExt> GenericConnection<C, Normal> { | |||
| password: T, | |||
| ) -> Result<String, ClientError> { | |||
| #[derive(Deserialize)] | |||
| struct JWT { | |||
| struct Jwt { | |||
There was a problem hiding this comment.
Clippy prefers this syntax
| @@ -134,7 +134,7 @@ impl<'a, C: ClientExt> Collection<C> { | |||
| /// characters only. Please refer to Naming Conventions in ArangoDB for more | |||
| /// information on valid collection names. | |||
| pub fn name(&self) -> &str { | |||
| &self.name.as_str() | |||
| self.name.as_str() | |||
There was a problem hiding this comment.
The borrowing was not needed
| @@ -150,7 +150,7 @@ impl<'a, __query, __count, __batch_size, __cache, __memory_limit, __ttl, __optio | |||
| ttl, | |||
| options, | |||
| ), | |||
| _phantom: self._phantom, | |||
| phantom: self.phantom, | |||
There was a problem hiding this comment.
typed_builder 0.9.1 requires this change
|
@fMeow the test failing on revision doesn't happen on ArangoDB 3.7.x and appears on 3.8.0 EDIT: It also appears on https://github.com/fMeow/arangors/runs/3419021859 so it's external to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #79
Also: