Remove incomplete local channel indexing #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dboas
approved these changes
Jul 22, 2024
sstucker
approved these changes
Aug 10, 2024
sreekanthkura7
added a commit
to sstucker/snirf
that referenced
this pull request
Aug 16, 2024
Remove following fields that are removed in PR fNIRS#151. data.measurementList.moduleIndex data.measurementList.sourceModuleIndex data.measurementList.detectorModuleIndex probe.useLocalIndex
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of local channel indexing is incomplete, because there is no defined mapping from local indices to global indices.
We further note that all practical purposes (e.g. analysis) a global index is required.
It is recognised that local indices do provide additional information. For example, there may be differing noise characteristics in the data which are dependent upon the local indices. However, capturing this information by means of indexing is vendor specific, and exploitation requires an intimate knowledge of the system.
If it is decided that such information should be retained, this should be done in a vendor agnostic and explicit manner. For example, in the case of noise characteristics, a per-channel noise distribution could be specified. But more generally, further design is required to understand how to most flexibilty translate the qualities of the acquistion system to the analysis phase, consider e.g., #141.
Thus, on balance, it has been decided to remove the current local indexing implementation.
We believe that the lack of specificaion of a mapping from local to global indexing means that it is not possible to have produced a compliant SNIRF file using local indexing, and hence this change is non-breaking.
Fix #106.