Remove python snirf validator #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a note. There is working being done at BU to update the SNIRF validator. I still suggest we remove it, then add it back when its working. I know of two labs that have sunk time in to using the current version, only to find out later that its not up to date. |
|
Thanks @fangq |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The python snirf validator library does not comply with current SNIRF specifications. As such, it should be removed as it simply adds confusion for users. Of course it should be added back if it is updated.
To confirm the library is non compliant, you can search for the required term
LengthUnitin the repository and it does not exist. I have not done a comprehensive check of all missing or incorrect fields.