-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make either 2D or 3D positions a requirement #69
Conversation
Good to hear this is being implemented! To ensure internal consistency within the document, the "SNIRF data format summary" section should probably be updated as well. There isn't an existing notation for "one of" - one option that comes to mind is:
But maybe there is another simpler notation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use detectorPos2D
to quote SNIRF field names.
also need to add a notation, say "**" or "+" in the summary table for the relevant fields
https://github.com/fNIRS/snirf/blob/master/snirf_specification.md#snirf-data-format-summary
for some reason, I feel that this solution is a bit cumbersome for future validator's/parsers, but don't have a better suggestion at this point.
Thanks for the review. @fangq does this look better? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks
Closes #65
This changes the specification to require either 2D or 3D positions, not just 2D.