Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock planner in tests #761

Merged
merged 5 commits into from
Jun 17, 2023
Merged

Mock planner in tests #761

merged 5 commits into from
Jun 17, 2023

Conversation

csegarragonz
Copy link
Collaborator

@csegarragonz csegarragonz commented Jun 5, 2023

In this PR we bump the faabric tag to include the planner mocking in the tests.

In practice, we only need to modify a couple of test cases to include the right planner test fixture.

@csegarragonz csegarragonz changed the title Bump faabric Mock planner in tests Jun 16, 2023
@csegarragonz csegarragonz self-assigned this Jun 16, 2023
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #761 (b7a4886) into main (850730c) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #761      +/-   ##
==========================================
- Coverage   67.40%   67.38%   -0.03%     
==========================================
  Files          69       69              
  Lines        7726     7726              
==========================================
- Hits         5208     5206       -2     
- Misses       2518     2520       +2     

see 2 files with indirect coverage changes

@csegarragonz csegarragonz merged commit 75a8b60 into main Jun 17, 2023
@csegarragonz csegarragonz deleted the mock-planner branch June 17, 2023 11:44
@csegarragonz csegarragonz mentioned this pull request Jun 17, 2023
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant