Compatibility with CLI mode #211
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So IDE can better help us
When in CLI mode `TYPO3_REQUEST` might not always exist. So we cannot access it blindly. Instead, we use the pattern officially recommended by `\TYPO3\CMS\Core\Http\ApplicationType`. Without this patch, extensions such as `messenger` would crash when sending emails.
|
rebased on latest master |
|
I missed your PR and was fixing that for another project at the same time... It is in the same spirit. Let me know if anything is not as it should. |
|
Nice ! It's pretty much same as mine, but better organized in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When in CLI mode
TYPO3_REQUESTmight not always exist. So we cannotaccess it blindly. Instead, we use the pattern officially recommended
by
\TYPO3\CMS\Core\Http\ApplicationType.Without this patch, extensions such as
messengerwould crash whensending emails.
Also see https://support.ecodev.ch/issues/9183