Testing search validation and unmarshal #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leodido
requested changes
Nov 29, 2017
api/search.go
Outdated
| @@ -3,8 +3,8 @@ package api | |||
| // TODO: validation | |||
|
|
|||
| type Attributes struct { | |||
| Attributes []string `json:"attributes,omitempty"` | |||
| ExcludedAttributes []string `json:"excludedAttributes,omitempty"` | |||
| Attributes []string `json:"attributes,omitempty"` // TODO: validate Attribute Notation | |||
api/search.go
Outdated
| Attributes []string `json:"attributes,omitempty"` | ||
| ExcludedAttributes []string `json:"excludedAttributes,omitempty"` | ||
| Attributes []string `json:"attributes,omitempty"` // TODO: validate Attribute Notation | ||
| ExcludedAttributes []string `json:"excludedAttributes,omitempty"` // TODO: validate Attribute Notation |
leodido
requested changes
Nov 29, 2017
api/search.go
Outdated
| @@ -3,8 +3,8 @@ package api | |||
| // TODO: validation | |||
|
|
|||
| type Attributes struct { | |||
| Attributes []string `json:"attributes,omitempty"` // TODO: validate Attribute Notation | |||
| ExcludedAttributes []string `json:"excludedAttributes,omitempty"` // TODO: validate Attribute Notation | |||
| Attributes []string `json:"attributes,omitempty" validate:"attrname"` | |||
There was a problem hiding this comment.
Conceptually correct, thanks.
Anyway you should create a new custom validator - ie., attrpath - and use it here ad per RFC 7644 attribute notation.
leodido
reviewed
Nov 29, 2017
api/attr/path.go
Outdated
| @@ -53,6 +55,14 @@ func Parse(s string) *Path { | |||
| return a | |||
| } | |||
|
|
|||
| func (a Path) Valid() bool { | |||
| s := a.Name | |||
There was a problem hiding this comment.
return len(a.Name) > 0 was too long?
There was a problem hiding this comment.
@leogr please use my style.
leodido
approved these changes
Nov 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.