Feature/homepage dashboard ms2 view lessons #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ko-` prefix is fairly unique and works really well when searching\ the codebase.
- add margins to ko-SrsIso so the root element size is the correct size, helps layout - tweak spacings on dashboard
If we want to re-introduce filtering the chart someday (RTK1, RTK3, ...) we should do it from the Vue template.
...based on the first uninterrupted range of flashcards from 1 to X
…file Since we already have a string of all kanjis in sequential order (in the "keywords" file used by the Study page) we can create an index map from that, no need to output on the php end. - add `rtk.ts` helpers to handle conversion between RTK & UCS indexes - fix Recognition page to use new helpers
- feed kanji card data into lesson view
- display colored tag on the card ("Restudy", "Box 2" etc)
- use custom keywords map + RTK keywords from keywords file,
using helpers in `rtk.ts`
…thod Issue console.assert only if the value is not set AND no default is provided.
- remove `fa-question-circle` icon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement top portion (Study & Review), and middle portion (Current Lesson view) of the new homepage prototype:
#241
There are still minor issues but it should be fully functional.
Known issues: