Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy images on commits on develop #11

Closed
vincentbrison opened this issue Mar 2, 2020 · 4 comments
Closed

Deploy images on commits on develop #11

vincentbrison opened this issue Mar 2, 2020 · 4 comments
Milestone

Comments

@vincentbrison
Copy link
Contributor

This would involve a new dedicated github action workflow, which would trigger build / test / deploy images on DockerHub. @sjcqs Do you have any idea how we should tag those images?

We should investigate how to add deploy capacity to ci.sh. It would probably involve secrets stored on github, for a dockerhub user / token.

@sjcqs
Copy link
Contributor

sjcqs commented Mar 2, 2020

Maybe we should deploy snapshots version of the develop branch and real release version of the master branch.

@sjcqs
Copy link
Contributor

sjcqs commented Mar 2, 2020

Images from the master branch would be android-xx and from the develop branch android-xx-snapshot

@sjcqs sjcqs added this to the v1 milestone Mar 2, 2020
@sjcqs
Copy link
Contributor

sjcqs commented Mar 2, 2020

We could also version the images, but this would require to either add manual tag to release a version (or use github version) or add sementic in the commit title/description (bugfix, feature, BREAKING CHANGE) to auto-compute the version name.

@vincentbrison
Copy link
Contributor Author

vincentbrison commented Mar 2, 2020

So image names may look like this:
fabernovel/android:api-29-latest (updated by any push on master)
fabernovel/android:api-29-v1.0.0 (semantic versioning for release through tag)
fabernovel/android:api-29-snapshot (uploaded by any push on develop)

What do you think about that?

@sjcqs sjcqs closed this as completed Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants