-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the usage of this image as a GitHub Action #45
Comments
What do you think about that @sjcqs ? |
Great idea 👍 I can take a look |
What need to be done:
References: |
Imho, we should focus for now to add shell input support, as action consumer can just throw some fastlane or gradle command to test what can be done with the action. Furthermore, as actions are already yml code versioned with the project, the need of shell input file might just be an option. About fastlane support, we dont need to do anything special as we would keep the following bloc in the action. So if the action consumer has a proper fastlane setup with proper - name: Bundle install
run: |
bundle config path vendor/bundle
bundle check || bundle install |
Well well, we can not use action inside an action. So no caching out of the box for now. Maybe we should at least include a default fastlane install (as we provide a default bundler install)? |
And to be able to run arbitrary docker-android image, we might need to use https://hub.docker.com/_/docker as host action image. |
I added branch https://github.com/faberNovel/docker-android/tree/feature/action to show an example on how to run docker in docker as mentioned in #45 (comment) |
Almost done, just need to pass command line args from action args to the docker image. |
As the GitHub Action shown in the README.md, we could add the ability to use this image as a GitHub action, letting the consumer of the action defining what he wants to do instead of fastlane call in our example.
Using GitHub Action args, we could enable/disable caching, and specifying docker image tag.
The text was updated successfully, but these errors were encountered: