Skip to content
This repository has been archived by the owner on May 25, 2023. It is now read-only.

Calculate market value sum in lineup #51

Closed
wants to merge 0 commits into from

Conversation

eLindros
Copy link

Maybe you find this feature also helpful.

It

  • calculates the sum of market values of selected players and
  • updates the budget and team value accordingly.

For me this is useful when deciding which player should I sell before the next game day:

feature

@eLindros eLindros force-pushed the develop branch 2 times, most recently from 61e99ed to 60181b7 Compare September 20, 2022 20:40
@Quotic
Copy link

Quotic commented Sep 21, 2022

Perfect for matchday planning

@fabfischer
Copy link
Owner

fabfischer commented Sep 22, 2022

Hi @eLindros ,

Thanks for the great feature. It's really a great help before a match day.

I'm just wondering if the whole feature wouldn't be better on the page "Sell". Or maybe it should be listed with its own menu item. Then you could also make the calculation more explicit and transparent. You could there also use current offers from Kickbase (incl. sales bonuses for 3, 5 or 10 mio profit).

What do you think?

I'm the rest of the week on the road. But I could support you from next week with this feature, if you like?

Fabian

@fabfischer fabfischer added the enhancement New feature or request label Sep 22, 2022
@eLindros
Copy link
Author

Hi @fabfischer,

I also thought about putting this feature on the "Sell" page. But then I decided otherwise. The reason is, that I need to have a look on my lineup when deciding which player to sell. It happened to me, that I sold a defender and had only two left, and -- there is no formation for that :-)

But then again. It would be nice to incorporate the actual offers and also sales bonuses. I was looking for a quick solution and went with the market value. Also -- I'm really a novice in web programming and my time is quite limited. But I'm definitely open to enhance this feature.

I'm on vacation next week. So we could start on that after October 3.

eLindros

@Quotic
Copy link

Quotic commented Oct 13, 2022

I would prefer as a user if there was an extra MatchDay planner page for this. Maybe you can also calculate statistics for the players, like point average last 3 games etc. but to keep the load of the API (number of calls) low, it only makes sense to query this separately from the lineup.

@fabfischer fabfischer added this to the v1.7 milestone Oct 31, 2022
@fabfischer
Copy link
Owner

Hi @eLindros ,

I will look into this feature asap. Perhaps you could rebase your PR onto the latest commit of the develop branch first? Thanks a lot!
@Quotic's idea about a "MatchDay planner page" with more stats sounds interesting. With the latest version statistics of a player are also fetched. However, currently this data is only kept in the component and not in the global store. But we could change this easily

@eLindros
Copy link
Author

eLindros commented Nov 3, 2022

Hi @fabfischer,

I needed to start over with my forked branch. Everything was quite messed up. I'm still pretty new to git and Github. Sorry. I will copy this feature in a new branch and start a new pull request.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants