Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question: what is the difference between value and equal validators #192

Closed
lo1tuma opened this issue Oct 1, 2023 · 2 comments
Closed

Question: what is the difference between value and equal validators #192

lo1tuma opened this issue Oct 1, 2023 · 2 comments
Assignees
@fabian-hiller
Labels
enhancement New feature or request

Comments

@lo1tuma
Copy link
Contributor

lo1tuma commented Oct 1, 2023

I’ve just looked at the code and it seems like they are almost identical.
@fabian-hiller
Copy link
Owner

Yes, you are right. In the beginning there was only equal. Then later we renamed minRange and maxRange to minValue and maxValue and added value in the same move so that the approach to the length, byte and size validation functions is consistent. We should probably deprecate equal.

@fabian-hiller fabian-hiller self-assigned this Oct 1, 2023
@fabian-hiller fabian-hiller added the enhancement New feature or request label Oct 1, 2023
fabian-hiller added a commit that referenced this issue Oct 8, 2023
@fabian-hiller
Deprecate equal validation in favor of value #192
982045e
@fabian-hiller
Copy link
Owner

Fixed in v0.19.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fabian-hiller fabian-hiller

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lo1tuma @fabian-hiller