-
-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Primitives values in literal schema #102
Primitives values in literal schema #102
Conversation
✅ Deploy Preview for valibot ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Great! Thanks a lot! I'll check your code as soon as I find time and publish this improvement with the next version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if null should be a primitive considering that null extends from object!
I think |
I have take the primitives data types from MDN Documentation that includes null and undefined between primitives values. |
Since this does not change the schema's implementation, it is not so important to me whether we include Feel free to give me feedback on this again. I'll probably decide tomorrow how I want to proceed. |
This PR add all primitives values on literal schema.
Solve Issue #97