Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bic validation #284

Merged
merged 6 commits into from
Dec 7, 2023

Conversation

ariskemper
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Dec 5, 2023

Deploy Preview for valibot ready!

Name Link
🔨 Latest commit 962bf94
🔍 Latest deploy log https://app.netlify.com/sites/valibot/deploys/65720ed255a92f0008d1326b
😎 Deploy Preview https://deploy-preview-284--valibot.netlify.app/404
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fabian-hiller
Copy link
Owner

Thank you for this contribution. I will review and merge this PR soon.

@fabian-hiller fabian-hiller self-assigned this Dec 5, 2023
@fabian-hiller fabian-hiller added the enhancement New feature or request label Dec 5, 2023
@ariskemper ariskemper marked this pull request as ready for review December 6, 2023 10:26
@fabian-hiller
Copy link
Owner

This PR is ready to merge. The only thing I am not sure about is the negative lookahead (?!00) in the regex. Based on Wikipedia, it seems to me that 00 is theoretically valid, but never used in practice.

@fabian-hiller fabian-hiller merged commit ae4ea35 into fabian-hiller:main Dec 7, 2023
10 checks passed
@fabian-hiller
Copy link
Owner

v0.23.0 is now available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants