You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am implementing this library, but now I run into the fact that the listener listens on an dispatch event with quite high priority. What is the reason for this?
As you are triggering a function renderAssets this does not make sense. For instance if your controller forwards to another controller, you cannot use that information because that happens on a lower prio dispatch event.
Could it be changed to trigger on render?
See \Fabiang\AsseticBundle\Listener->attach
The text was updated successfully, but these errors were encountered:
As far as I can see it's important for the check for acceptable errors. This and the priority of 32 comes from the original fork. Without further testing I assume the event listener could be changed to the events MvcEvent::EVENT_RENDER and MvcEvent::EVENT_RENDER_ERROR, since the error should be available too there.
Honestly this library, while still supported by me, is very low on my priority list, as there are better solutions out there for managing assets. So if you willing to do further investigations and open a pull request, I'm happy to merge the solution.
Hi,
I am implementing this library, but now I run into the fact that the listener listens on an dispatch event with quite high priority. What is the reason for this?
As you are triggering a function renderAssets this does not make sense. For instance if your controller forwards to another controller, you cannot use that information because that happens on a lower prio dispatch event.
Could it be changed to trigger on render?
See \Fabiang\AsseticBundle\Listener->attach
The text was updated successfully, but these errors were encountered: