always set "logical size" for render

[rfomin]

This fixes screen stretching if aspect_ratio_correct == 0.

Before:

After:

The size of the window in windowed mode is not corrected, should we change it too?

[SoDOOManiac]

I'm not sure if this should be done at all, for square pixels we have aspect_ratio_correct == 2.

[rfomin]

I'm not sure if this should be done at all, for square pixels we have aspect_ratio_correct == 2.

Wow, this is a super secret option, I didn't know about it. But why do we need aspect_ratio_correct == 0? For users, it looks broken.

[SoDOOManiac]

aspect_ratio_correct == 0 makes sense for scaling the framebuffer to old 1280x1024 displays, their aspect ratio is 1.25 which is less than the 'classic aspect ratio corrected' 1.33(3).

[rfomin]

scaling the framebuffer to old 1280x1024 displays

What if that becomes aspect_ratio_correct == 2? I think most users want non-stretched mode.

[SoDOOManiac]

What if that becomes aspect_ratio_correct == 2? I think most users want non-stretched mode.

IMO the logic of aspect_ratio_correct == 0 is no correction, just scaling the classic framebuffer to the full display as-is, without maintaining any specific pixel aspect ratio.
aspect_ratio_correct == 1 is for scaled pixel height/width = 1.2, and aspect_ratio_correct == 2 corresponds to scaled pixel aspect ratio = 1 for players who want non-distorted automap and perfectly spherical fireballs.

[rfomin]

This may be logical, but from the user's perspective on a standard 16:9 screen it looks broken. How are users supposed to know about the aspect_ratio_correct == 2?

[SoDOOManiac]

How are users supposed to know about the aspect_ratio_correct == 2?

That should probably be documented in the readme :)

Anyway, to change aspect_ratio_correct in Crispy you have to edit crispy-doom.cfg file, and reading the manual would be logical before changing that.

[fabiangreffrath]

I think aspect_ratio_correct with values 0 and 1 behave exactly the same as in Chocolate Doom. We just added value 2 for people who want non- corrected fixed 1:1 ratio.

[rfomin]

I think aspect_ratio_correct with values 0 and 1 behave exactly the same as in Chocolate Doom.

In the current master - yes. But in version 3.0 (which people use) aspect_ratio_correct == 0 works differently, like in this PR or in Crispy's aspect_ratio_correct == 2

Anyway, to change aspect_ratio_correct in Crispy you have to edit crispy-doom.cfg file, and reading the manual would be logical before changing that.

Let's face it - no one reads the manual. I think the aspect_ratio_correct in the config file is self explanatory.

[SoDOOManiac]

In the current master - yes. But in version 3.0 (which people use) aspect_ratio_correct == 0 works differently, like in this PR or in Crispy's aspect_ratio_correct == 2

Yes, in v3.0.1 (which is 3.0.0 with just one critical security exploit fixed IIRC) aspect_ratio_correct == 0 gives square pixels.
But is was changed later for some reason, I deem, and probably that should be discussed with Chocolate team.

[fabiangreffrath]

In the current master - yes. But in version 3.0 (which people use) aspect_ratio_correct == 0 works differently, like in this PR or in Crispy's aspect_ratio_correct == 2

But Crispy always builds upon the latest Choco master. So, if we change it back to Choco 3.0 state now and Choco 3.1 gets released in 2030 we would still carry the behaviour of the outdated 3.0 release, and not version 3.1 that everybody uses. 😉

[rfomin]

It's this change: chocolate-doom#1002 I contend that this new behavior should not be the default, I have a user request that it is broken and I myself was of the same opinion.

[rfomin]

If you disable aspect ratio correction on a standard 16x9 monitor, you end up with an extremely stretched image - who needs that? As an alternative, I suggest adding widescreen support for the "square pixels" case.

[fabiangreffrath]

If you disable aspect ratio correction on a standard 16x9 monitor, you end up with an extremely stretched image - who needs that? As an alternative, I suggest adding widescreen support for the "square pixels" case.

Honestly, I don't know. I was never convinced of this idea, that's why I introduced the aspect_ratio_correct == 2 solution in Crispy. If you could move this discussion back to Choco (with a PR to revert the commit in question, or add the aspect_ratio_correct == 2 solution from Crispy) I'd be thankful.

[SoDOOManiac]

I suggest adding widescreen support for the "square pixels" case.

I voted against removing it in the first place :)
This line was without == 1 before:

crispy-doom/src/i_video.c

Line 1637 in 4c0a56a

if (crispy->widescreen && aspect_ratio_correct == 1)

There's even no need to change the comment, because the phrase 'widescreen makes no sense without aspect ratio correction' implies that for square pixels aspect ratio correction is in effect, just enforcing a different pixel aspect ratio value