fix: Various type extractions #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #159 +/- ##
==========================================
+ Coverage 97.33% 97.38% +0.04%
==========================================
Files 14 14
Lines 676 688 +12
Branches 275 278 +3
==========================================
+ Hits 658 670 +12
Misses 18 18
|
|
I'm very late to review this, but this looks amazing!!! Thanks for this amazing contribution |
fabien0102
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Various expressions where not taken into account when extracting types, thus leading to missing schema in output generation.
The two latter ones were implemented in #152 and #155 which I close to merge all fixes in this PR.
Support of TypeScript Helpers
The following helpers were not handled well:
["Array", "Promise", "Omit", "Pick", "Record", "Partial", "Required"]when used in expressions such as
Add support for ParenthesisTypeNodes
This was added in #152 (closed) following this comment: #148 (comment)
Type identifiers not extracted from type alias declaration
This was added in #155 (closed)
Extracting types from expression such as
was not working