Fixes #36 | Allows for single value unions #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #37 +/- ##
==========================================
- Coverage 98.49% 98.05% -0.45%
==========================================
Files 8 9 +1
Lines 332 359 +27
Branches 102 108 +6
==========================================
+ Hits 327 352 +25
- Misses 5 6 +1
- Partials 0 1 +1
Continue to review full report at Codecov.
|
fabien0102
reviewed
Jul 29, 2021
| @@ -168,6 +168,13 @@ describe("generateZodSchema", () => { | |||
| ); | |||
| }); | |||
|
|
|||
| it("should generate a literal schema for a single union", () => { | |||
| const source = `export type Identity = | "superman";`; | |||
There was a problem hiding this comment.
I was not even aware of this notation 😅 make totally sense!
There was a problem hiding this comment.
Haha ya I use it to remind myself this will be a union but haven't filled out everything yet. Typescript is pretty rad :P (And so is ts-to-zod, it's super useful!!)
fabien0102
pushed a commit
that referenced
this pull request
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixes #36. Handles single value unions how typescript handles them.