-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for native Typescript enums #38
Conversation
Codecov Report
@@ Coverage Diff @@
## main #38 +/- ##
==========================================
- Coverage 98.49% 98.07% -0.42%
==========================================
Files 8 9 +1
Lines 332 364 +32
Branches 102 110 +8
==========================================
+ Hits 327 357 +30
- Misses 5 6 +1
- Partials 0 1 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just remove this commented line and we are good to go, thanks for this addition!
Let's also add a little test into |
Closing in favor of #40. Handled the feedback on the other pr. |
|
* Checks in test documenting behavior * Implements enum import & declartion * Updates example to include enum * Updates tests to document expected case * Add handler for enum literals * Updates example * Addresses #38 (comment) * Addresses #38 (comment) * Addresses #40 (comment)
…40) * Checks in test documenting behavior * Implements enum import & declartion * Updates example to include enum * Updates tests to document expected case * Add handler for enum literals * Updates example * Addresses #38 (comment) * Addresses #38 (comment) * Addresses #40 (comment)
Why
Fixes #35 by adding support for native typescript enums