-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added cli_serializer & from_cli function #311
Added cli_serializer & from_cli function #311
Conversation
@Denperidge thank you very much for this PR! I see there are some errors on Python 3.8, could you fix them? |
My pleasure! Got the error! The exit_on_error option got added in 3.9. But because of the error catching that is done further down, it should be redundant either way. Take your time to review, and have a nice day! |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #311 +/- ##
==========================================
+ Coverage 96.44% 96.54% +0.09%
==========================================
Files 61 62 +1
Lines 1857 1909 +52
==========================================
+ Hits 1791 1843 +52
Misses 66 66
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@Denperidge released within |
Amazing, thanks for helping me integrate it! @fabiocaccamo Have a nice day ♥ |
Thank you for your great contribution! |
name: Pull request
about: Submit a pull request for this project
assignees: fabiocaccamo
Describe your changes
Related issue/discussion
#290
Extra notes:
Checklist before requesting a review