-
-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not use script-wide use strict statement #49
Comments
thanks, looking into this |
That seems to be automatically added by one of the preprocessors as it isn't present in the actual _wrapper.js file. I am trying to track down which one is doing it, and I think 6to5 is likely the culprit. Since 6to5 is now Babel, it may be worthwhile to migrate over to Babel to get the latest updates. |
@shshaw This is somewhat of a big issue. I've problems with including different libraries when they're included after |
Yeah, I want to fix this as well. It's tied into #93 ( and #90 / #92 ), which is a big change to the build process. @simeydotme was helping with this, but I'm not sure if he's made any more progress. If you have Babel experience or can help with the build process, then please contribute. |
Unfortunately I don't have experience with Babel nor 6to5. |
Unfortunately I don't either 😄 I've stumbled around with it a bit, but their documentation is quite cryptic, so I haven't wanted to deploy anything without someone experienced taking a look. |
Took another stab at this, and managed a gulp-free build process using babel and uglify. Pushed to the build-revision branch. Please try it out and let me know if you find any issues. |
Works for me! |
This will be addressed in the next milestone. |
Fixed in v2.1.3. It was surprisingly tricky to implement, the minifiers kind of got in the way. |
You are using a script-wide form of use strict statement. This may cause problems with minimizing. You can use a function form instead:
There is more explanation on the following stackoverflow-thread: stackoverflow link
The text was updated successfully, but these errors were encountered: