Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event binding for $(window) and $(document) #51

Closed
lvanengelen opened this issue May 1, 2015 · 2 comments
Closed

Event binding for $(window) and $(document) #51

lvanengelen opened this issue May 1, 2015 · 2 comments
Assignees
@kenwheeler
Labels
bug

Comments

@lvanengelen
Copy link

$.fn.on() fails on them, because the code tries to call $.fn.data(). This fails because window and document do not support getAttribute()
@kenwheeler
Copy link
Collaborator

nice catch

@kenwheeler kenwheeler added the bug label May 29, 2015
@kenwheeler kenwheeler self-assigned this May 29, 2015
@kenwheeler kenwheeler mentioned this issue Feb 27, 2016
Merged
shshaw added a commit to shshaw/cash that referenced this issue Mar 4, 2016
@shshaw
window fixes
1c5b2f1 
- Fix for selecting `window` in collection
- `.attr` support for `window` & `document` which do not have
`getAttribute` / `setAttribute`, which in turn fixes issue fabiospampinato#51 where
events could not be registered
- `.removeProp` added
@shshaw shshaw mentioned this issue Mar 4, 2016
Merged
@shshaw shshaw mentioned this issue Apr 12, 2016
Closed
@shshaw
Copy link
Collaborator

shshaw commented Apr 12, 2016

This should work as expected as of 1.1.0.

@shshaw shshaw closed this as completed Apr 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kenwheeler kenwheeler

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kenwheeler @shshaw @lvanengelen