EventCache: Replaced property access to WeakMap access #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per fabiospampinato#383. Chrome 36+, Edge 12+, Safari 8+, Firefox 6+, Opera 23+, IE 11+ [caniuse - WeakMap](https://caniuse.com/?search=WeakMap()) Besides, `"lib": ["ES2015.Collection"]` is added to `tsconfig.json` (`Map`, `Set`, `WeakMap`, `WeakSet` are added to TypeScript)
cyfung1031
added a commit
to cyfung1031/jquery-cash
that referenced
this pull request
May 3, 2023
As per introduction of `WeakMap` in fabiospampinato#423 and dropped `initEvent` with IE11 in fabiospampinato#422.
How so? I see an object with a prototype being created just the same. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #383. Shall resolve #317 as well. Once PR merged, closes #383.
Chrome 36+, Edge 12+, Safari 8+, Firefox 6+, Opera 23+, IE 11+
caniuse - WeakMap
Besides,
"lib": ["ES2015.Collection"]is added totsconfig.json(
Map,Set,WeakMap,WeakSetare added to TypeScript)Please note that, element clone would not copy the event cache. This matches the result that
element.cloneNode(true)would not copy the event handlers attached to the original node.