1.3 race fix #141
Merged
1.3 race fix #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 6, 2022 16:50
…end and (b) making both NetworkX backends thread safe using local locking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #131 by adding locking around sensitive parts of NetworkXPropertyGraph and NetworkXPropertyGraphDisjoint storage implementations. Both are equivalent and for now the NetworkXPropertyGraph still remains the default for when you create an ExperimentTopology(). If the other backend is desired (there probably isn't really a compelling reason to do it, but..):
will create an experiment topology with a disjoint back end. As I mentioned - there won't be any performance improvement, I don't think since both the usual and the disjoint back ends have locking now.
This is pushed to PyPi as fim-1.3.3