Skip to content
This repository has been archived by the owner on May 6, 2021. It is now read-only.

Setup GolangCI and add goal in makefile #18

Closed
xcoulon opened this issue Oct 17, 2018 · 0 comments · Fixed by #19
Closed

Setup GolangCI and add goal in makefile #18

xcoulon opened this issue Oct 17, 2018 · 0 comments · Fixed by #19
Assignees
@xcoulon
Labels
type/enhancement New feature or request
Milestone
Sprint 156

Comments

@xcoulon
Copy link
Contributor

xcoulon commented Oct 17, 2018

see conversation in https://chat.openshift.io/developers/pl/3j4rti6np78mmm86n81iqsf1ea
@xcoulon xcoulon added the type/enhancement New feature or request label Oct 17, 2018
@xcoulon xcoulon self-assigned this Oct 17, 2018
@xcoulon xcoulon mentioned this issue Oct 17, 2018
Merged
xcoulon added a commit that referenced this issue Oct 18, 2018
@xcoulon
feat: configure GolangCI and use linter in makefile (#19)
61e5272 
also remove govet, golint and gocyclo goals: replaced with golangci linters

fixes #18

Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
@xcoulon xcoulon added this to the Sprint 156 milestone Nov 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@xcoulon xcoulon

Labels
type/enhancement New feature or request
Projects
None yet
Milestone
Sprint 156
Development

Successfully merging a pull request may close this issue.

feat: configure GolangCI and use linter in makefile
1 participant
@xcoulon