This repository has been archived by the owner on Mar 11, 2021. It is now read-only.
Update design to allow custom attributes in call to Notification service #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
main.go
Outdated
| @@ -78,6 +78,7 @@ func main() { | |||
| resolvers.Register("workitem.update", collector.ConfiguredVars(config, collector.NewWorkItemResolver(witClient))) | |||
| resolvers.Register("comment.create", collector.ConfiguredVars(config, collector.NewCommentResolver(witClient))) | |||
| resolvers.Register("comment.update", collector.ConfiguredVars(config, collector.NewCommentResolver(witClient))) | |||
| resolvers.Register("user.email.update", collector.ConfiguredVars(config, collector.NewUserResolver(witClient))) | |||
There was a problem hiding this comment.
added a fork of workitem.update template where I stripped out almost everything. Will make it look pretty 8f42085
sbose78
changed the title
|
Used the workitem.update template to have a super simple email verification template till have something nicer done ( by myself or UX :) )
|
sbose78
changed the title
aslakknutsen
suggested changes
Dec 19, 2017
| @@ -80,6 +81,13 @@ func (a *AsyncWorkerNotifier) do(cn contextualNotification) { | |||
|
|
|||
| return | |||
| } | |||
|
|
|||
| if vars == nil { | |||
There was a problem hiding this comment.
Can't assume vars is null here..
template/user.email.update/body.html
Outdated
| max-width: 700px; | ||
| text-align: left;"> | ||
| <h3 style="margin-bottom: 5px;"> | ||
| <a href="{{.custom.VerifyURL }}" style=" |
There was a problem hiding this comment.
Normal would be a camelcase style variable..
| @@ -0,0 +1,2 @@ | |||
| In-Reply-To: <workitems/{{.workitem.Data.ID}}@notify.openshift.io> | |||
There was a problem hiding this comment.
No workitem in the auth context. None of these headers make any sense.. ?
|
@aslakknutsen , thank you for the review - I've addressed the comments. |
5 tasks
aslakknutsen
suggested changes
Dec 20, 2017
|
Thanks @aslakknutsen added some more tests |
|
Added a validator of the optional |
aslakknutsen
approved these changes
Dec 22, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for passing a
customparameter to thenotifyAPI.This would be used to pass the verifyCode for an updated email.
Part of fabric8-services/fabric8-auth#62