Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config / RequestConfig rollingTimeout is unused #4826

Closed
shawkins opened this issue Feb 2, 2023 · 1 comment · Fixed by #4877
Closed

Config / RequestConfig rollingTimeout is unused #4826

shawkins opened this issue Feb 2, 2023 · 1 comment · Fixed by #4877
Milestone
6.5.0

Comments

@shawkins
Copy link
Contributor

shawkins commented Feb 2, 2023

This appears to predate the recent changes to aggregate some of the timeout logic and blocking delete. It should be used in the event that the context timeout is unset and passed to the rolling update.
@shawkins
Copy link
Contributor Author

shawkins commented Feb 3, 2023

getUploadConnectionTimeout is no longer used, the more general getWebsocketTimeout is used instead.

shawkins added a commit to shawkins/kubernetes-client that referenced this issue Feb 14, 2023
@shawkins
fix fabric8io#4826: refining / deprecating rollout logic
78cd3a2 
this means there's no reason to keep the rollingTimeout RequestConfig
option
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Feb 14, 2023
@shawkins
fix fabric8io#4826: refining / deprecating rollout logic
acd664b 
this means there's no reason to keep the rollingTimeout RequestConfig
option
@shawkins shawkins mentioned this issue Feb 14, 2023
Merged
11 tasks
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Feb 15, 2023
@shawkins
fix fabric8io#4826: refining / deprecating rollout logic
a28d024 
this means there's no reason to keep the rollingTimeout RequestConfig
option
manusa pushed a commit to shawkins/kubernetes-client that referenced this issue Feb 20, 2023
@shawkins @manusa
fix fabric8io#4826: refining / deprecating rollout logic
6e7d55d 
this means there's no reason to keep the rollingTimeout RequestConfig
option
@manusa manusa added this to the 6.5.0 milestone Feb 20, 2023
manusa pushed a commit that referenced this issue Feb 20, 2023
@shawkins @manusa
fix #4826: refining / deprecating rollout logic
8fc4291 
this means there's no reason to keep the rollingTimeout RequestConfig
option
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Feb 20, 2023
@shawkins
fix fabric8io#4826: removed RequestConfig upload connection and rolli…
f12e14b 
…ng timeouts
@shawkins shawkins mentioned this issue Feb 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.5.0
Development

Successfully merging a pull request may close this issue.

fix #4826: refining / deprecating rollout logic shawkins/kubernetes-client
2 participants
@manusa @shawkins