Fixes Issue 2306: make Informers work with KubernetesServer CRUD mode #2396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
oscerd
approved these changes
Aug 10, 2020
lalithsuresh
force-pushed
the
issue2306
branch
from
d5cf4c7
to
44f2cc1
Compare
|
Rebasing against master (e8c47dc) to avoid merge conflict in CHANGELOG.md |
rohanKanojia
approved these changes
Aug 11, 2020
|
May I know why the license check is failing? The logs don't reveal why. |
kubernetes-tests/src/test/java/io/fabric8/kubernetes/client/mock/CrudInformerTest.java
Outdated
Show resolved
Hide resolved
|
Not sure If I'm right here but if we're adding informers support to the crud mock server.. shouldn't we also update the resourceVersion of the resource when it's updated? |
…mers This is addressed by making sure that MockWebServer returns a metadata object for list queries. Signed-off-by: Lalith Suresh <lsuresh@vmware.com>
Signed-off-by: Lalith Suresh <lsuresh@vmware.com>
lalithsuresh
force-pushed
the
issue2306
branch
from
44f2cc1
to
6192238
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
manusa
approved these changes
Aug 19, 2020
|
[merge] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2306: make Informers work with KubernetesServer CRUD mode
Type of change
test, version modification, documentation, etc.)
Checklist