-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes Issue 2306: make Informers work with KubernetesServer CRUD mode #2396
Conversation
Can one of the admins verify this patch? |
d5cf4c7
to
44f2cc1
Compare
Rebasing against master (e8c47dc) to avoid merge conflict in CHANGELOG.md |
May I know why the license check is failing? The logs don't reveal why. |
kubernetes-tests/src/test/java/io/fabric8/kubernetes/client/mock/CrudInformerTest.java
Outdated
Show resolved
Hide resolved
Not sure If I'm right here but if we're adding informers support to the crud mock server.. shouldn't we also update the resourceVersion of the resource when it's updated? |
…mers This is addressed by making sure that MockWebServer returns a metadata object for list queries. Signed-off-by: Lalith Suresh <lsuresh@vmware.com>
Signed-off-by: Lalith Suresh <lsuresh@vmware.com>
44f2cc1
to
6192238
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
[merge] |
Description
Fixes #2306: make Informers work with KubernetesServer CRUD mode
Type of change
test, version modification, documentation, etc.)
Checklist