-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix : change the docker-registry secret's name to be configurable. #4200
fix : change the docker-registry secret's name to be configurable. #4200
Conversation
…registry-secret )
...etes-client-api/src/main/java/io/fabric8/kubernetes/client/utils/KubernetesResourceUtil.java
Outdated
Show resolved
Hide resolved
This reverts commit cadecec.
...etes-client-api/src/main/java/io/fabric8/kubernetes/client/utils/KubernetesResourceUtil.java
Show resolved
Hide resolved
@sunix now we can create docker-registry-secret with default name( "docker-registry-secret") or secretName param |
...etes-client-api/src/main/java/io/fabric8/kubernetes/client/utils/KubernetesResourceUtil.java
Outdated
Show resolved
Hide resolved
...etes-client-api/src/main/java/io/fabric8/kubernetes/client/utils/KubernetesResourceUtil.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx!
@manusa |
Kudos, SonarCloud Quality Gate passed! |
thx 😄 |
Description
in this PR (#3321), createDockerRegistrySecret() makes a secret named "harbor-secret"
I think the name of secret should be "docker-registry-secret"
++
now createDockerRegistrySecret() makes a secret named "container-image-registry-secret"
also we can create docker-registry-secret with secretName param
Type of change
test, version modification, documentation, etc.)
Checklist