Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vertx client #4744

Merged
merged 16 commits into from
Jan 12, 2023
Merged

Vertx client #4744

merged 16 commits into from
Jan 12, 2023

Conversation

shawkins
Copy link
Contributor

@shawkins shawkins commented Jan 8, 2023 •
edited by manusa
Loading

Description

Relates to #2764
Relates to quarkusio/quarkus#29520

We are close enough to full functionality to open a pr with the current state of the branch. I have updated to master and added the connection test - but that is currently failing with stack overflow errors.

cc @vietj

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@shawkins shawkins marked this pull request as ready for review January 12, 2023 15:04
@manusa
feat(vertx): support for 8192 simultaneous connections
1f3273b 
Signed-off-by: Marc Nuri <marc@marcnuri.com>
@sonarcloud
Copy link

sonarcloud bot commented Jan 12, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

77.3% 77.3% Coverage
0.0% 0.0% Duplication

@manusa manusa added this to the 6.4.0 milestone Jan 12, 2023
@manusa manusa merged commit e2926c0 into master Jan 12, 2023
@manusa manusa deleted the vertx-client branch January 12, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscerd oscerd oscerd approved these changes

@manusa manusa manusa approved these changes

@rohanKanojia rohanKanojia Awaiting requested review from rohanKanojia

@sunix sunix Awaiting requested review from sunix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@shawkins @manusa @oscerd @vietj