Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub issue 923 #956

Merged
merged 8 commits into from
Dec 28, 2017
Merged

Conversation

rohanKanojia
Copy link
Member

Add more CRUD tests #923

@oscerd
Copy link
Member

oscerd commented Dec 18, 2017

ok to test

@rohanKanojia
Copy link
Member Author

rohanKanojia commented Dec 18, 2017

Hey, i have a doubt. Could anyone please give me any example of simple update case. In almost all the test cases i've been unable to do an edit operation. For example, take a look at SecretCrudTest.java . If i uncomment that edit section i get an error like this :

Dec 18, 2017 12:20:38 PM okhttp3.mockwebserver.MockWebServer$2 acceptConnections
INFO: MockWebServer[42605] done accepting connections: Socket closed
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 3.199 sec <<< FAILURE! - in io.fabric8.kubernetes.client.mock.SecretCrudTest
testCrud(io.fabric8.kubernetes.client.mock.SecretCrudTest)  Time elapsed: 3.08 sec  <<< ERROR!
java.lang.NullPointerException
	at io.fabric8.kubernetes.client.mock.SecretCrudTest.testCrud(SecretCrudTest.java:78)


Results :

Tests in error: 
  SecretCrudTest.testCrud:78 » NullPointer

Tests run: 1, Failures: 0, Errors: 1, Skipped: 0

I'm not sure if i'm doing it the right way or maybe there is some bug in Kubernetes mock server in CRUD mode. All the other tests also show same error in case of edit. Plus there were some failures in Deployment related resources as well. I've filed a github issue for this here.

@oscerd
Copy link
Member

oscerd commented Dec 18, 2017

Open an issue for that and we can take a look.

@oscerd
Copy link
Member

oscerd commented Dec 18, 2017

@iocanel would you mind take a look here? Can we merge and take a look at the edit operation later?

@iocanel
Copy link
Member

iocanel commented Dec 28, 2017

Rebased and addressed the edit issue.

Note: I am not sure if its even possible to a edit a resources name. It definitely causes issues in our crud tests. I replaced it with adding a label instead.

Copy link
Member

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iocanel
Copy link
Member

iocanel commented Dec 28, 2017

[merge]

@fusesource-ci fusesource-ci merged commit 91d70bf into fabric8io:master Dec 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants