-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub issue 923 #956
GitHub issue 923 #956
Conversation
ok to test |
Hey, i have a doubt. Could anyone please give me any example of simple update case. In almost all the test cases i've been unable to do an edit operation. For example, take a look at SecretCrudTest.java . If i uncomment that edit section i get an error like this :
I'm not sure if i'm doing it the right way or maybe there is some bug in Kubernetes mock server in CRUD mode. All the other tests also show same error in case of edit. Plus there were some failures in Deployment related resources as well. I've filed a github issue for this here. |
Open an issue for that and we can take a look. |
@iocanel would you mind take a look here? Can we merge and take a look at the edit operation later? |
149d843
to
61b4802
Compare
Rebased and addressed the edit issue. Note: I am not sure if its even possible to a edit a resources name. It definitely causes issues in our crud tests. I replaced it with adding a label instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[merge] |
Add more CRUD tests #923