fix(Canvas): safeguard canvas add #7866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removes objet from previous canvas when adding to a new one
ShaMan123
changed the title
Code Coverage Summary |
Code Coverage Summary |
Code Coverage Summary |
asturur
reviewed
Apr 5, 2022
| 'Resulting to default behavior: removing object from previous canvas and adding to new canvas'); | ||
| /* _DEV_MODE_END_ */ | ||
| obj.canvas.remove(obj); | ||
| } |
There was a problem hiding this comment.
i think this is totally fair, because the old reference in the canas would be just a broken reference.
i used this a couple of times to render objects in different canvases for copy purposes, the thing i was doing was to swap the canvas reference manually, while now i should go through the add/remove process and avoid extra renders.
There was a problem hiding this comment.
Do we want to check for duplicates as well? I think it's damaging for perf and I don't see too much advantage for it
There was a problem hiding this comment.
if we do we can do in the dev mode braket and remove it in prod build.
asturur
approved these changes
Apr 5, 2022
|
This exposed a regression for toCanvasElement. |
ShaMan123
added a commit
that referenced
this pull request
Apr 26, 2022
#7866 exposed a regression when using `toCanvasElement` This commit fixes it and fixes another issue: `object.toCanvasElement()` would fire an added event which is absolutely undesired
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes object from previous canvas when adding to a new one