-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Canvas): dispose
race condition
#7885
Conversation
Code Coverage Summary
|
Code Coverage Summary
|
Code Coverage Summary
|
The PR seems fine to me, and seem innocent enough to merge it without digging deeper. |
Is approved, so you can merge whenever. But try to explain |
Yes. What happened was that Canvas#dispose nullified topContext and there was a small gap of time that rendering could occur before StaticCanvas#dispose terminated requested rendering. |
…d-properties-null-reading-save Implement Fabric PR fabricjs#7885
calling static dispose before interactive dispose to prevent race condition as described in #7876
should close #7876 and some other strange bugs.