Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(TS): convert file ext #8108

Merged
merged 16 commits into from
Aug 2, 2022
Merged

chore(TS): convert file ext #8108

merged 16 commits into from
Aug 2, 2022

Conversation

ShaMan123
Copy link
Contributor

@ShaMan123 ShaMan123 commented Aug 2, 2022 •
edited
Loading

  • convert file ext under src
  • @ts-nocheck for build to pass
  • build script patch - to kill build if a new build is about to start in watch mode

@ShaMan123 ShaMan123 changed the title chore(TS): converet file ext chore(TS): convert file ext Aug 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022 •
edited
Loading

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.16 |    74.55 |   84.49 |   80.74 |                                               
 fabric.js |   82.16 |    74.55 |   84.49 |   80.74 | ...,27464,27474-27518,27626,27713,27917,28058 
-----------|---------|----------|---------|---------|-----------------------------------------------

@ShaMan123
Copy link
Contributor Author

it's just lint that is failing because TS

@ShaMan123 ShaMan123 requested a review from asturur August 2, 2022 11:15
ShaMan123
ShaMan123 commented Aug 2, 2022
View reviewed changes
.eslintrc.json Outdated
],


// TODO: remove the following for TS, just temporary 08/22
Copy link
Contributor Author

@ShaMan123 ShaMan123 Aug 2, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these actually do a really good job
they convert whatever they can from var to let/const
I didn't commit the fixes to keep the diff clean

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022 •
edited
Loading

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.15 |    74.52 |   84.49 |   80.73 |                                               
 fabric.js |   82.15 |    74.52 |   84.49 |   80.73 | ...,27464,27474-27518,27626,27713,27917,28058 
-----------|---------|----------|---------|---------|-----------------------------------------------

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022 •
edited
Loading

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.16 |    74.55 |   84.49 |   80.74 |                                               
 fabric.js |   82.16 |    74.55 |   84.49 |   80.74 | ...,27464,27474-27518,27626,27713,27917,28058 
-----------|---------|----------|---------|---------|-----------------------------------------------

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022 •
edited
Loading

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.16 |    74.55 |   84.49 |   80.74 |                                               
 fabric.js |   82.16 |    74.55 |   84.49 |   80.74 | ...,27464,27474-27518,27626,27713,27917,28058 
-----------|---------|----------|---------|---------|-----------------------------------------------

@ShaMan123
update testem
7819b02 
 Invalid 'main' field in '/home/runner/work/fabric.js/fabric.js/node_modules/fireworm/package.json' of 'fireworm.js'. Please either fix that or report it to the module author
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022 •
edited
Loading

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.16 |    74.55 |   84.49 |   80.74 |                                               
 fabric.js |   82.16 |    74.55 |   84.49 |   80.74 | ...,27464,27474-27518,27626,27713,27917,28058 
-----------|---------|----------|---------|---------|-----------------------------------------------

@ShaMan123
upgrade eslint
f508939 
> fabric@5.1.0 lint
> npm run jslint && npm run tslint

> fabric@5.1.0 jslint
> eslint --config .eslintrc.json src/**/*.js

Oops! Something went wrong! :(

ESLint: 8.18.0

No files matching the pattern "src/**/*.js" were found.
Please check for typing mistakes in the pattern.

Error: Process completed with exit code 2.
@ShaMan123
Update package.json
5c39f0a
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022 •
edited
Loading

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.15 |    74.52 |   84.49 |   80.73 |                                               
 fabric.js |   82.15 |    74.52 |   84.49 |   80.73 | ...,27464,27474-27518,27626,27713,27917,28058 
-----------|---------|----------|---------|---------|-----------------------------------------------

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022 •
edited
Loading

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.16 |    74.55 |   84.49 |   80.74 |                                               
 fabric.js |   82.16 |    74.55 |   84.49 |   80.74 | ...,27464,27474-27518,27626,27713,27917,28058 
-----------|---------|----------|---------|---------|-----------------------------------------------

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022 •
edited
Loading

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.16 |    74.55 |   84.49 |   80.74 |                                               
 fabric.js |   82.16 |    74.55 |   84.49 |   80.74 | ...,27464,27474-27518,27626,27713,27917,28058 
-----------|---------|----------|---------|---------|-----------------------------------------------

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022 •
edited
Loading

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.15 |    74.52 |   84.49 |   80.73 |                                               
 fabric.js |   82.15 |    74.52 |   84.49 |   80.73 | ...,27464,27474-27518,27626,27713,27917,28058 
-----------|---------|----------|---------|---------|-----------------------------------------------

@ShaMan123
revert
5529ba9 
it doesn't make linting pass so....
ShaMan123
ShaMan123 commented Aug 2, 2022
View reviewed changes
Copy link
Contributor Author

@ShaMan123 ShaMan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couldn't get lint to pass no matter what

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022 •
edited
Loading

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.16 |    74.55 |   84.49 |   80.74 |                                               
 fabric.js |   82.16 |    74.55 |   84.49 |   80.74 | ...,27464,27474-27518,27626,27713,27917,28058 
-----------|---------|----------|---------|---------|-----------------------------------------------

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022 •
edited
Loading

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |    82.2 |    74.55 |   84.49 |   80.78 |                                               
 fabric.js |    82.2 |    74.55 |   84.49 |   80.78 | ...,27464,27474-27518,27626,27713,27917,28058 
-----------|---------|----------|---------|---------|-----------------------------------------------

@asturur asturur merged commit adfdb4b into master Aug 2, 2022
@asturur asturur deleted the simply-ts branch September 11, 2022 23:03
frankrousseau pushed a commit to cgwire/fabric.js that referenced this pull request Jan 6, 2023
@ShaMan123 @frankrousseau
chore(TS): convert file ext (fabricjs#8108)
3d63dbc 
- chore rework
- added a lint rule that does nothing ( abogazzi )
Co-authored-by: Andrea Bogazzi <andreabogazzi79@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asturur asturur asturur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShaMan123 @asturur