-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(TS): Color #8115
chore(TS): Color #8115
Conversation
Code Coverage Summary
|
Code Coverage Summary
|
src/util/index.ts
Outdated
composeMatrix, | ||
rotatePoint | ||
}; | ||
export default fabric.util; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's not use default exports, is a mess when we mix default and named exports.
Let's merge this PR. But in general this kind of extraction i think is actual code more than a bunch of import/exports that goes away at rollup time. I would like to use named exports only unless we have some kind of concerns internally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For sure
I want named exports as well.
Just for hacking the build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well maybe we should remove this line
nothing should use it
Code Coverage Summary
|
Co-authored-by: Andrea Bogazzi <andreabogazzi79@gmail.com>
Color
classI have created a patch index for util so we can start importing from there
I don't like that the history isn't kept between
src/color.class.ts
->src/color/color.class.ts
so I think we should open a PR that only moves the file and then merge this one and do that in future PRsEDITED
Merge #8116 BEFORE this PR, update from master and merge this