Fix() safeguard access to possibly undefined canvas #8722
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix unguarded reference for
object.canvas
Description
this.canvas.getRetinaScaling()
call can cause TypeError in current release in some cases. It happened with us few times.Would be really helpful to get this fix as soon as possible. I saw it already fixed in @beta, but I don't see it coming at the nearest future.
Changes
Enhance
.drawControls
method with guard for.getRetinaScaling
call. Set default retinaScaling to 1.In Action
Smallest example to represent an issue. This is a bit far-fetched but represents edge cases which could happen in huge variety of race conditions.
Steps: Try to move object on canvas.
https://codesandbox.io/s/fabricjs-playground-forked-hpodkw