-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(e2e): fix babel compiling error #9388
Conversation
fs.watch on wondows throws on file removal https://github.com/nodejs/help/issues/4252
Build Stats
|
…into ci-babel-fix
Update CONTRIBUTING.md
eeeab61
to
4327611
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DONE
please merge asap
|
||
// watch | ||
if (process.argv.includes('--ui')) { | ||
const watcher = watch( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super flaky on windows but good enough to move on
if this removes local development headaches i m all for it Also i think windows is a pain for node development, does it work properly if you run it on the linux subsystem? or is flaky there? |
I don't know |
Motivation
Babel has a silent bug (on windows at least) - it doesn't comiple the files if using babel cli from a spawned call or something like that. It does not throw.
What it means is that when I run e2e tests they will fail ungracefully and I will be the only one to know why.
When I run e2e tests I must copy the cmd from
playwright.setup.ts
and run it with npx for babel to pick it up correctly.Description
Move away from using babel cli via a spawn call to using the API directly.
Changes
Gist
In Action