Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activating qLogNEI by default for all BotorchModels #1792

Closed

Conversation

SebastianAment
Copy link
Contributor

Summary: This commit changes the default acquisition function for all BotorchModels from qNEI to qLogNEI.

Differential Revision: D48610442

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 23, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48610442

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48610442

SebastianAment added a commit to SebastianAment/Ax that referenced this pull request Aug 23, 2023
Summary:
Pull Request resolved: facebook#1792

This commit changes the default acquisition function for all `BotorchModels` from `qNEI` to `qLogNEI`.

Reviewed By: Balandat

Differential Revision: D48610442

fbshipit-source-id: d8270cc2b5a5e285c93ec0bc9de695e8edd23559
@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (d1b9fb7) 94.56% compared to head (aa3c0eb) 94.56%.

❗ Current head aa3c0eb differs from pull request most recent head 0139c0c. Consider uploading reports for the commit 0139c0c to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1792      +/-   ##
==========================================
- Coverage   94.56%   94.56%   -0.01%     
==========================================
  Files         454      454              
  Lines       42736    42733       -3     
==========================================
- Hits        40414    40410       -4     
- Misses       2322     2323       +1     
Files Changed Coverage Δ
ax/modelbridge/tests/test_registry.py 99.62% <ø> (+0.37%) ⬆️
ax/models/torch/botorch.py 98.38% <ø> (ø)
ax/models/torch/botorch_moo.py 98.93% <ø> (ø)
ax/modelbridge/factory.py 96.96% <100.00%> (ø)
ax/models/tests/test_alebo.py 100.00% <100.00%> (ø)
ax/models/tests/test_botorch_moo_model.py 97.54% <100.00%> (ø)
ax/models/torch/alebo.py 97.89% <100.00%> (ø)
ax/models/torch/fully_bayesian.py 96.91% <100.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48610442

SebastianAment added a commit to SebastianAment/Ax that referenced this pull request Aug 24, 2023
Summary:
Pull Request resolved: facebook#1792

This commit changes the default acquisition function for all `BotorchModels` from `qNEI` to `qLogNEI`.

Reviewed By: Balandat

Differential Revision: D48610442

fbshipit-source-id: 66d239e162e4d4669b2e63806126668bdc3466c5
Summary:
Pull Request resolved: facebook#1792

This commit changes the default acquisition function for all `BotorchModels` from `qNEI` to `qLogNEI`.

Reviewed By: Balandat

Differential Revision: D48610442

fbshipit-source-id: 1a48ead5ed8b394ecb2c140b205ca2f3643f7395
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48610442

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 3a701d8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants