-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activating qLogNEI
by default for all BotorchModels
#1792
Conversation
This pull request was exported from Phabricator. Differential Revision: D48610442 |
This pull request was exported from Phabricator. Differential Revision: D48610442 |
Summary: Pull Request resolved: facebook#1792 This commit changes the default acquisition function for all `BotorchModels` from `qNEI` to `qLogNEI`. Reviewed By: Balandat Differential Revision: D48610442 fbshipit-source-id: d8270cc2b5a5e285c93ec0bc9de695e8edd23559
c0318ab
to
b972d66
Compare
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #1792 +/- ##
==========================================
- Coverage 94.56% 94.56% -0.01%
==========================================
Files 454 454
Lines 42736 42733 -3
==========================================
- Hits 40414 40410 -4
- Misses 2322 2323 +1
☔ View full report in Codecov by Sentry. |
This pull request was exported from Phabricator. Differential Revision: D48610442 |
Summary: Pull Request resolved: facebook#1792 This commit changes the default acquisition function for all `BotorchModels` from `qNEI` to `qLogNEI`. Reviewed By: Balandat Differential Revision: D48610442 fbshipit-source-id: 66d239e162e4d4669b2e63806126668bdc3466c5
b972d66
to
0139c0c
Compare
Summary: Pull Request resolved: facebook#1792 This commit changes the default acquisition function for all `BotorchModels` from `qNEI` to `qLogNEI`. Reviewed By: Balandat Differential Revision: D48610442 fbshipit-source-id: 1a48ead5ed8b394ecb2c140b205ca2f3643f7395
This pull request was exported from Phabricator. Differential Revision: D48610442 |
0139c0c
to
9455c24
Compare
This pull request has been merged in 3a701d8. |
Summary: This commit changes the default acquisition function for all
BotorchModels
fromqNEI
toqLogNEI
.Differential Revision: D48610442