Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates trial status during clone #2290

Closed

Conversation

bernardbeckerman
Copy link
Contributor

Summary: Updates cloned trial's status to match the trial from which it was cloned. This will eventually help us deduplicate some of warm_start_from_old_experiment.

Differential Revision: D55024671

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Mar 19, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55024671

@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 85.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 94.90%. Comparing base (d120362) to head (1764cd7).

❗ Current head 1764cd7 differs from pull request most recent head dc41d40. Consider uploading reports for the commit dc41d40 to get more accurate results

Files Patch % Lines
ax/global_stopping/tests/tests_strategies.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2290      +/-   ##
==========================================
- Coverage   94.90%   94.90%   -0.01%     
==========================================
  Files         489      489              
  Lines       47656    47687      +31     
==========================================
+ Hits        45229    45257      +28     
- Misses       2427     2430       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bernardbeckerman pushed a commit to bernardbeckerman/Ax that referenced this pull request Mar 26, 2024
Summary:

Updates cloned trial's status to match the trial from which it was cloned. This will eventually help us deduplicate some of warm_start_from_old_experiment.

Reviewed By: mpolson64

Differential Revision: D55024671
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55024671

bernardbeckerman pushed a commit to bernardbeckerman/Ax that referenced this pull request Mar 26, 2024
Summary:

Updates cloned trial's status to match the trial from which it was cloned. This will eventually help us deduplicate some of warm_start_from_old_experiment.

Reviewed By: mpolson64

Differential Revision: D55024671
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55024671

bernardbeckerman pushed a commit to bernardbeckerman/Ax that referenced this pull request Mar 26, 2024
Summary:

Updates cloned trial's status to match the trial from which it was cloned. This will eventually help us deduplicate some of warm_start_from_old_experiment.

Reviewed By: mpolson64

Differential Revision: D55024671
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55024671

Summary:

Updates cloned trial's status to match the trial from which it was cloned. This will eventually help us deduplicate some of warm_start_from_old_experiment.

Reviewed By: mpolson64

Differential Revision: D55024671
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55024671

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 7491233.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants