Fix test_compare_to_baseline_equal #2296
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Remove log checking from test_compare_to_baseline_equal Context: D54885250 moved some logs from INFO to DEBUG, breaking this test which checked for logs at the INFO level. However, we cant just change the level in the assertLogs context manager to DEBUG because *DEBUG logs are silent by default in Ax* -- the default log level is INFO. IMO we should just remove this test, and maybe remove the logs too. Right now its impossible for them to be seen by the user, and will only be visible to developers if they manually change the level of the logger in report_utils in source. If we were concerned enough about logspew to move these out of INFO, maybe we should just get rid of them altogether. Thoughts? Reviewed By: bernardbeckerman Differential Revision: D55248686
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55248686 |
|
This pull request has been merged in 3a701af. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Remove log checking from test_compare_to_baseline_equal
Context: D54885250 moved some logs from INFO to DEBUG, breaking this test which checked for logs at the INFO level. However, we cant just change the level in the assertLogs context manager to DEBUG because DEBUG logs are silent by default in Ax -- the default log level is INFO.
IMO we should just remove this test, and maybe remove the logs too. Right now its impossible for them to be seen by the user, and will only be visible to developers if they manually change the level of the logger in report_utils in source. If we were concerned enough about logspew to move these out of INFO, maybe we should just get rid of them altogether. Thoughts?
Reviewed By: bernardbeckerman
Differential Revision: D55248686