Make filtering cheaper - do not create wrapper object when we are not… #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… going to use given node
ghost
added
| FBObjectGraphConfiguration *configuration, | ||
| NSArray<NSString *> *namePath) { | ||
| if (_ShouldBreakGraphEdge(configuration, sourceElement, [namePath objectAtIndex:0], object_getClass(object))) { |
There was a problem hiding this comment.
objectAtIndex: will crash (raise an exception) if the index is out of bounds. firstObject will return nil instead of crashing, so might wanna switch. I haven't backtracked to see where namePath comes from, maybe it's guaranteed to always have non-zero count.
|
Other than the few comments, looks good 👍 |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… going to use given node. Right now we just simply create wrapped object for every possible case, but this tends to be very ineffective when we are for example creating wrapper objects around NSStrings