Misjudged on retained cycle #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Gricha Firstly, I'm sorry for @ you. I want to pull request, but the checks alway fail. I checked the reason of fail. That's about simulator SDK, I have not changed any thing about the project. I don't know how to fix it too. Could you give me some suggestions? |
|
@without2002 Sorry for radio silence. I've started fixing Travis integration. Once that's done we can get deep into the PR. Thanks! |
|
Hi @without2002, do you still want this checked in and pulled? |
Merged
|
I opened #49 to improve some of the operations for speed. I doubt @without2002 is still interested in pushing this after over a year of waiting but the credit is definitely his. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Gricha, thank you for your reply. I have added the code to filter result of cycle detector. Please check it.
PS: I'm sorry for that I posted the issue to FBMemoryProfiler repo, but I think the code should in FBRetainCycleDetector project. So I can't link the issue. The link of issue is here: facebookarchive/FBMemoryProfiler#35