Track local memos in profiling #134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D24189842 |
DylanZA
pushed a commit
to DylanZA/Haxl
that referenced
this pull request
Oct 16, 2020
Summary: Pull Request resolved: facebook#134 Local memos should be profiled too. If users do not want this, it would be trivial to add a field to MemoCall to show what type of memo it is, but I do not think it is necesary. Reviewed By: anubhav94N Differential Revision: D24189842 fbshipit-source-id: 8e1e4c020b42972bebf1da453ef9bac6803206a3
DylanZA
force-pushed
the
export-D24189842
branch
from
e91fceb
to
4982382
Compare
|
This pull request was exported from Phabricator. Differential Revision: D24189842 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D24189842 |
DylanZA
pushed a commit
to DylanZA/Haxl
that referenced
this pull request
Oct 16, 2020
Summary: Pull Request resolved: facebook#134 Local memos should be profiled too. If users do not want this, it would be trivial to add a field to MemoCall to show what type of memo it is, but I do not think it is necesary. Reviewed By: anubhav94N Differential Revision: D24189842 fbshipit-source-id: d37c1f8aaafb194894bd772bf23f0a8fe920bf35
DylanZA
force-pushed
the
export-D24189842
branch
from
4982382
to
b106057
Compare
Summary: Pull Request resolved: facebook#134 Local memos should be profiled too. If users do not want this, it would be trivial to add a field to MemoCall to show what type of memo it is, but I do not think it is necesary. Reviewed By: anubhav94N Differential Revision: D24189842 fbshipit-source-id: fd89bed339b88a7d909bd21a9d9632731455de15
|
This pull request was exported from Phabricator. Differential Revision: D24189842 |
DylanZA
force-pushed
the
export-D24189842
branch
from
b106057
to
c6cb79e
Compare
|
This pull request has been merged in 3918e2c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Local memos should be profiled too.
If users do not want this, it would be trivial to add a field to MemoCall to show what type of memo it is, but I do not think it is necesary.
Reviewed By: anubhav94N
Differential Revision: D24189842